Skip to content

fix: pass transfer params subspace to TransferKeeper#136

Closed
kpitapeersyst wants to merge 1 commit into
mainfrom
fix/transferkeeper-nil
Closed

fix: pass transfer params subspace to TransferKeeper#136
kpitapeersyst wants to merge 1 commit into
mainfrom
fix/transferkeeper-nil

Conversation

@kpitapeersyst
Copy link
Copy Markdown
Contributor

@kpitapeersyst kpitapeersyst commented May 4, 2026 •
edited by coderabbitai Bot
Loading

fix: pass transfer params subspace to TransferKeeper

Motivation 💡

  • The transfer keeper was initialized with a nil params subspace.

Changes 🛠

  • Pass app.GetSubspace(ibctransfertypes.ModuleName) into transferkeeper.NewKeeper.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Transfer module initialization to ensure module parameters are properly sourced from the configuration subsystem, improving reliability and consistency of inter-blockchain transfer operations across the network.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b7776fa6-fd14-40f7-8834-4ef443da57ea

📥 Commits

Reviewing files that changed from the base of the PR and between 43c1c36 and 8b4ac24.

📒 Files selected for processing (1)
  • app/app.go
📝 Walkthrough

Walkthrough

The Transfer module's keeper initialization now receives the IBC Transfer types module subspace instead of nil, enabling proper parameter/configuration sourcing during keeper construction.

Changes

Transfer Module Keeper Configuration

Layer / File(s) Summary
Keeper Initialization
app/app.go		 transferkeeper.NewKeeper now receives app.GetSubspace(ibctransfertypes.ModuleName) instead of nil for the subspace argument.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A keeper once stood in the void so bare,
With nary a subspace to tend and care,
But now it receives its rightful place,
The module's own subspace, wrapped with grace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: passing the transfer params subspace to TransferKeeper instead of nil.
Description check ✅ Passed The description covers Motivation and Changes sections as required by the template, though the Considerations and Dependencies sections are omitted.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/transferkeeper-nil

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdriaCarrera
Copy link
Copy Markdown
Contributor

AdriaCarrera commented May 18, 2026

Closing as this issue is not relevant, paramskeeper is deprecated and not used

@AdriaCarrera AdriaCarrera deleted the fix/transferkeeper-nil branch May 18, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kpitapeersyst @AdriaCarrera